Add SUSE Manager Clear Settings dialog
#2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
enhancement
jamie-suse
force-pushed
the
suma-settings-page
branch
from
6599456
to
d47897c
Compare
|
Not 100% sure if this component should have it's own directory. Open to moving it somewhere else if it makes more sense. |
nelsonkopliku
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Not 100% sure if this component should have it's own directory. Open to moving it somewhere else if it makes more sense.
I am ok with this proposal. I guess you took inspiration from SuseManagerSettingsDialog component.
By the way in the design the button is filled in red, not only outlined
dottorblaster
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the dialog that will open when the user clicks the "Clear Settings" button on the Settings page.
It prompts the user to either confirm or cancel that they wish to clear the SUSE Manager credentials from Trento.
See Storybook link for interactive demo.
How was this tested?
Add React component tests and a Storybook story.