Add Clear Software Updates settings Saga
#2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
enhancement
jamie-suse
force-pushed
the
clear-settings-saga
branch
from
eb20f2b
to
fde5af1
Compare
dottorblaster
requested changes
Feb 20, 2024
Comment on lines
74
to
75
| const errors = get(error, ['response', 'data', 'errors'], []); | ||
| yield put(setSoftwareUpdatesSettingsErrors(errors)); |
There was a problem hiding this comment.
I think there's no need to set errors, this is meant for validation errors in other sagas
nelsonkopliku
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Redux Saga to allow the user to clear Software Updates settings.
How was this tested?
Added tests for the Saga.