Connect sagas to the actual SUSE Manager config UI #2356
Conversation
dottorblaster
force-pushed
the
connect-sagas-suse-manager-edit
branch
4 times, most recently
from
d1741a9
to
05f8871
Compare
There was a problem hiding this comment.
Looking great!
Besides the two minor comments the main issues I found are:
- on saving when the certificate is left empty in the ui
ca_cert: ""is passed to the api which does not pass validation. If the certificate is not wanted then theca_certproperty should not be in the api request payload. - similarly, when patching settings if we want to remove the certificate, we need to provide the api with
ca_cert: nullinstead ofca_cert: ""otherwise the same validation would not pass.
|
@nelsonkopliku thanks for catching that behavior, I applied the fixes 👍 |
There was a problem hiding this comment.
Almost there.
Saving is working correctly, ca_cert is not sent if the user did not provide any 👍
On update, however, we need an explicit ca_cert: null if we want to remove the certificate, currently the field is not sent at all, meaning it remains untouched.
Besides this the Remove action seems to not be retained in the modal when changing creds like cert or password.
dottorblaster
force-pushed
the
connect-sagas-suse-manager-edit
branch
2 times, most recently
from
25f08cb
to
e2f0491
Compare
|
@nelsonkopliku thanks! It should be okay now.
I didn't quite understand this, but I guess you mean that closing and reopening the modal should display the |
|
Thank you! 😄 |
dottorblaster
force-pushed
the
connect-sagas-suse-manager-edit
branch
from
99b4411
to
722920f
Compare
* Connect sagas to the actual SUSE Manager config UI * Apply fixes from review * Fix linting error about else after return
Description
Connecting the actual settings page to the settings API for SUSE Manager integration.
How was this tested?
Jest tests updates, added new ones