Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for "SUSE Manager config enabled" #2362

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Add flag for "SUSE Manager config enabled" #2362

merged 1 commit into from
Feb 23, 2024

Conversation

jamie-suse
Copy link
Contributor

@jamie-suse jamie-suse commented Feb 23, 2024

Description

This PR adds a flag to enable the SUSE Manager config. When the flag is enabled:

  • The API endpoints for SUSE Manager credentials are enabled
  • The SUSE Manager config is available in the Settings page

Also added a helper library getFromConfig() that retrieves a variable from the global config object. This way we don't need to add the line // eslint-disable-next-line no-undef everywhere when we need to read values from the global config.

How was this tested?

Add unit tests for the getFromConfig() library.

@jamie-suse jamie-suse added enhancement New feature or request javascript Pull requests that update Javascript code elixir Pull requests that update Elixir code labels Feb 23, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the tiny comment LGTM.

Do you think we can also get rid of fun_with_flags from deps? 👀

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 E DAJE

@jamie-suse jamie-suse merged commit 8116511 into main Feb 23, 2024
24 checks passed
@jamie-suse jamie-suse deleted the suma-flag branch February 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

None yet

3 participants