Add expect enum usage #2370
Merged
Add expect enum usage #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
add-expect-enum-usage
branch
from
9b85560
to
dee4256
Compare
EMaksy
reviewed
Feb 29, 2024
| export const EXPECT_SAME = 'expect_same'; | ||
|
|
||
| const hostExepectations = [EXPECT, EXPECT_ENUM]; |
There was a problem hiding this comment.
Just a quick question here, we have multiple files in model directory.
Like cluster.js, sapSystem.js and index.js
What kind of data should we always put in index.js?
For now, it is mostly cluster details view related.
There was a problem hiding this comment.
well, that's subjective, as long as it doesn't go out of control having one file is convenient
CDimonaco
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
expect_enumresults usage. This means that the host expectations are now ofexpectandexpect_enum, and the results in the result detail view could be of warning type.Example in storybook:
How was this tested?
Tested with UT