Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Api key expiration checking routine #2384

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Add Api key expiration checking routine #2384

merged 2 commits into from
Mar 5, 2024

Conversation

CDimonaco
Copy link
Member

Description

This PR adds a new quantum routine to check each day if the api key is expired.
When the api key expiration is less then 30 days, an email is sent.
When the api key expires an email is sent.

The email are sent until the api key is generated again with a new expiration.
No email are sent if the api key expiration is infinite

image
image

How was this tested?

Automated tests

@CDimonaco CDimonaco added enhancement New feature or request elixir Pull requests that update Elixir code labels Mar 5, 2024
@CDimonaco CDimonaco requested a review from arbulu89 March 5, 2024 10:03
@CDimonaco CDimonaco self-assigned this Mar 5, 2024
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Just some nitpick comments

Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code apart, it looks good to me @CDimonaco !

@CDimonaco CDimonaco merged commit c302053 into main Mar 5, 2024
24 checks passed
@CDimonaco CDimonaco deleted the api_key_alerts branch March 5, 2024 14:04
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (wasn't able to review in time but still all looks good)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

4 participants