Add empty state to sbd details #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
added
enhancement
EMaksy
force-pushed
the
add_sbd_fencing_empty_state
branch
from
cf5ec46
to
4707d08
Compare
EMaksy
force-pushed
the
add_sbd_fencing_empty_state
branch
2 times, most recently
from
74bf272
to
fff75bb
Compare
EMaksy
force-pushed
the
add_sbd_fencing_empty_state
branch
from
fff75bb
to
196f88f
Compare
EMaksy
force-pushed
the
add_sbd_fencing_empty_state
branch
2 times, most recently
from
21fd658
to
813a9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add an empty state message for the SBD Details component in the case there are no sbd devices. Instead of just rendering the title, we render a text which informs the user.
Why?
When using disk-based SDB fencing, the SBD/fencing section in the cluster details view shows the configured SBD devices and whether they are in healthy or unhealthy status.
When using diskless SBD fencing, there are no SBD devices. Therefore, the SBD/fencing section should inform the user with a message.
Demo
Before:
After (Check Storybook):
How was this tested?
Added test and story