Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrap prop to tooltip #2389

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add wrap prop to tooltip #2389

merged 1 commit into from
Mar 7, 2024

Conversation

dottorblaster
Copy link
Contributor

@dottorblaster dottorblaster commented Mar 6, 2024

Description

Our tooltip component wraps elements in a span by default. In order not to mess up with CSS styles in some flexbox/grid context this behavior needs to be turned off on demand.

How was this tested?

Jest tests added

@dottorblaster dottorblaster added the enhancement New feature or request label Mar 7, 2024
@dottorblaster dottorblaster self-assigned this Mar 7, 2024
@dottorblaster dottorblaster marked this pull request as ready for review March 7, 2024 10:26
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jamie-suse jamie-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dottorblaster dottorblaster merged commit 3d60957 into main Mar 7, 2024
24 checks passed
@dottorblaster dottorblaster deleted the tooltip-wrap-prop branch March 7, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants