Don't return error when deleting non-existent CA cert file #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
bug
nelsonkopliku
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #2391
If the SUMA GenServer attempts to delete a certificate file that doesn't exist, it will return an error status. This should not be considered an error case for our use-case and so we should use
File.rm_rf/1instead, which specifically ignores this.This behaviour/symptom also surfaced with some flakiness in the test
"should not save CA certificate file if no cert is provided", where sometimesSuma.setup(@test_integration_name)returned the aforementioned{:error, :enoent}, due to the nondeterministic nature of the order of operations.How was this tested?
Flakiness of unit test
"should not save CA certificate file if no cert is provided"should be fixed.