Display SUMA updates in Host Details page #2430
Conversation
jamie-suse
added
enhancement
jamie-suse
force-pushed
the
suma-updates
branch
from
19cee66
to
752dc59
Compare
jamie-suse
force-pushed
the
suma-updates
branch
from
752dc59
to
a7be359
Compare
| relevantPatches={numRelevantPatches} | ||
| upgradablePackages={numUpgradablePackages} | ||
| softwareUpdatesLoading={softwareUpdatesLoading} |
There was a problem hiding this comment.
Maybe we wanna add a tooltip text as a prop here? I really don't know, and I really don't wanna block this PR just for this nit
There was a problem hiding this comment.
Done. Do you think it's worth testing this tooltip behaviour from HostDetails.test.jsx, as it's already being tested in AvailableSoftwareUpdates.test.jsx... 🤔
There was a problem hiding this comment.
No, I think we can iterate over that, for example in the future we can have a selector to determine tooltip's text
| @@ -66,6 +78,7 @@ function HostDetailsPage() { | |||
| getExportersStatus(); | |||
| refreshCatalog(); | |||
| dispatch(updateLastExecution(hostID)); | |||
| dispatch(fetchSoftwareUpdates(hostID)); | |||
There was a problem hiding this comment.
this needs to be like the following
| dispatch(fetchSoftwareUpdates(hostID)); | |
| dispatch(fetchSoftwareUpdates({hostId: hostID})) |
unless we change that action
There was a problem hiding this comment.
Hmm just had a look through our codebase and we use a mix of hostID and hostId 🤔 I guess hostID is more popular though, so I'll change the action
There was a problem hiding this comment.
up to you, but the thing is we need to pass an object, not the plain id (whatever is called).
unless we do transformation in the action
export const createAction = createAction(
FETCH_SOFTWARE_UPDATES,
(hostId) => ({ payload: { hostId } })
);There was a problem hiding this comment.
Ah I see what you mean. I thought I was using the action-creator in @state/softwareUpdates. Instead, I was calling the Saga directly 😳
Description
This change mounts the
AvailableSoftwareUpdatescomponent in the Host Details page, allowing users to see the available updates and patches for a host, as instructed by SUMA.How was this tested?
Added React component tests to validate that the Available Software Updates component is correctly being displayed in the Host Details page.