Make Software Updates service handle no SUMA settings saved
#2457
Conversation
jamie-suse
added
enhancement
jamie-suse
force-pushed
the
handle-no-saved-suma-settings
branch
from
b45eecd
to
d0d8b06
Compare
lib/trento/software_updates.ex
Outdated
| else | ||
| {:error, reason} -> {:error, :unable_to_get_software_updates, reason} |
There was a problem hiding this comment.
| else | |
| {:error, reason} -> {:error, :unable_to_get_software_updates, reason} |
| def call(conn, {:error, :unable_to_get_software_updates, :not_found}), | ||
| do: call(conn, {:error, :not_found}) | ||
|
|
||
| def call(conn, {:error, :unable_to_get_software_updates, reason}) do | ||
| conn | ||
| |> put_status(:unprocessable_entity) | ||
| |> put_view(ErrorView) | ||
| |> render(:"422", reason: get_failure_message(reason)) | ||
| end | ||
|
|
There was a problem hiding this comment.
I actually like single clauses to be more explicit. A fallback controller shouldn't manage this kind of errors in an implicit way, Could you just declare one more clause instead of having this refactoring?
|
hey @dottorblaster, Jamie and I paired a bit on this, so let me share some rationale: Since it seems (@jamie-suse could you confirm, please?) that this differentiation is not strictly needed now (and it can be done in many ways) I believe we could defer any further fine grained error handling for now. That said, we surely can just add In any case I guess we have room to improve error handling, and this relates also to the discussion you raised some days ago that ended up in the possibility to have contextual fallback controller. But let's of course defer that 😄 Hope the context helps 😉 |
There was a problem hiding this comment.
@nelsonkopliku all clear, thank you! Of course the status quo always has room for improvement, let's keep this on the radar, thank you so much!
Description
This changes allows the
Software Updatesservice to return an error with a response status of422and provides the message "SUSE Manager settings not configured.".How was this tested?
Updated existing unit tests to validate new behaviour.