Dynamic catalog filters #2475
Merged
Dynamic catalog filters #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alog state/saga/selector
nelsonkopliku
added
enhancement
…og instead of the filtered one
nelsonkopliku
force-pushed
the
dynamic-catalog-filters
branch
from
6ac1824
to
0bd9801
Compare
jamie-suse
reviewed
Apr 3, 2024
jamie-suse
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows filters in the catalog page to be populated based on the whole catalog content, while the actual list below is based on a filteredCatalog.
This requires making a differentiation in the intent: loading the whole catalog vs getting a filtered version of it, and I ended up adding this tiny seed
filteredCatalog: truein theupdateCatalogaction.However, I am not totally happy with it.
I attempted polishing catalog state and saga even further, but that would require rationalizing everything catalog related and updating many other places where the catalog is queried, like the checks selection, checks result page, etc... then I preferred keeping the change at minimum and defer further refactoring.
How was this tested?
Automated tests