Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read SUSE Manager Enabled flag from config in HostDetailsPage #2477

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jamie-suse
Copy link
Contributor

Description

Refactor to read the suseManagerEnabled flag from the config from the HostDetailsPage stateful wrapper component instead of in the pure HostDetails component.

How was this tested?

Updates to unit tests and Storybook stories for HostDetails component.

@jamie-suse jamie-suse added the javascript Pull requests that update Javascript code label Mar 26, 2024
@jamie-suse jamie-suse self-assigned this Mar 26, 2024
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@jamie-suse jamie-suse merged commit 8469773 into main Mar 26, 2024
28 checks passed
@jamie-suse jamie-suse deleted the suma-enabled-host-details branch March 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

None yet

3 participants