Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suma url overlap #2488

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix suma url overlap #2488

merged 2 commits into from
Apr 3, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Apr 3, 2024

Description

Truncating longer suma urls with an ellipsis.
image

How was this tested?

Visually on pr environment https://2488.prenv.trento.suse.com/ and storybook

@nelsonkopliku nelsonkopliku self-assigned this Apr 3, 2024
@nelsonkopliku nelsonkopliku added bug Something isn't working env Create an ephimeral environment for the pr branch labels Apr 3, 2024
Copy link
Contributor

@jagabomb jagabomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku merged commit 8d4a965 into main Apr 3, 2024
24 checks passed
@nelsonkopliku nelsonkopliku deleted the fix-suma-url-overlap branch April 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working env Create an ephimeral environment for the pr branch
Development

Successfully merging this pull request may close these issues.

None yet

2 participants