Handle requests for software updates discoveries from Host aggregate #2507
Conversation
nelsonkopliku
force-pushed
the
trigger-software-updates-process-from-host-aggregate
branch
from
f2e0b02
to
c64dcca
Compare
There was a problem hiding this comment.
Hey @nelsonkopliku ,
The approach looks correct.
Just a couple of things:
- we don't need to use the
multias we don't need to get any change from previous events in this event - i think we can simply the new
maybe_functions, solution proposed
Besides that, all good
There was a problem hiding this comment.
Hey @nelsonkopliku ,
As the solution you propose is correct, I'm giving a green light.
I proposed other solution that I think is better (my opinion).
But in any case, it is ok to move forward
|
nelsonkopliku
deleted the
trigger-software-updates-process-from-host-aggregate
branch
| ] ++ | ||
| maybe_emit_software_updates_discovery_events( | ||
| host_id, | ||
| current_fully_qualified_domain_name, |
There was a problem hiding this comment.
Shouldn't this 2nd argument be nil here?
I mean, I understood that in this circunstance we don't want to emit the Cleared event, but if the new fqdn is nil, and we had a value before (current), it would be emitted, or not?
There was a problem hiding this comment.
yep, I guess I missed that test.
Here we go #2518
Thanks!
Description
This PR moves the logic for software updates discovery inside the host aggregate which is going to emit a
SoftwareUpdatesDiscoveryRequestedin the following scenarios:Additionally when the fqdn of the host transitions from a meaningful value to
nullwe take care of dispatching aClearSoftwareUpdatesDiscoveryfor clean up purposes.Following this we will have a
SoftwareUpdatesDiscoveryEventHandlerlistening toSoftwareUpdatesDiscoveryRequestedgetting information from suma and dispatching back aCompleteSoftwareUpdatesDiscoverycommandWhen implementing the new event handler some minor changes to
Trento.SoftwareUpdates.Discoverymight be needed. Here's some referenceHow was this tested?
Automated tests