Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Trento.Type error handling and adds tests #252

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Fix Trento.Type error handling and adds tests #252

merged 1 commit into from
Mar 28, 2022

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Mar 28, 2022 •
edited

Fixes #251

arbulu89
arbulu89 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@dottorblaster dottorblaster merged commit 50020a9 into main Mar 28, 2022
@dottorblaster dottorblaster deleted the fix_type_errors branch March 28, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@arbulu89 arbulu89 arbulu89 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using new! in case of nested errors raises without reporting the actual error
4 participants
@fabriziosestito @dottorblaster @nelsonkopliku @arbulu89