Fix empty relevant patches visualization #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
added
bug
arbulu89
force-pushed
the
fix-empty-relevant-patches-visualization
branch
from
b5166d4
to
6f5ac7e
Compare
jamie-suse
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix empty relevant patches visualization. When relevant patches is coming as an empty list (all green!), a unknown icon was being shown.
Some type missmatch between string and int (thank you js).
In fact, storybook and the tests were done in a way that actual failure was masked hehe
Check the PR env to see the
0value and other value for hostsvmdrbddev02(unknown) andvmhdbdev01(2 patches).Damn: the PR env doesn't show what I want, as it doesn't mock suma calls as expected, as it is released as
prodHow was this tested?
Tests updated, and manually confirmed