Properly clear suma genserver state when clearing software updates settings #2530
Conversation
nelsonkopliku
added
bug
nelsonkopliku
force-pushed
the
fix-suma-settings-clearup
branch
from
51c5428
to
e56f3e9
Compare
There was a problem hiding this comment.
Yes, I think it is better to clean in any scenario.
Anyway, the clear simply cleans the auth cookie, right?
I don't know how that could affect doing not needed discoveries, but well, still think it is a good change. I guess we spare one potentially useless query to suma, that would fail.
|
@arbulu89 the problem was that when clearing up suma settings when there were no hosts in the system did clear the entry in the database but not the genserver state 🙈 |
|
Yes, but the gen server state was supposed to be rebuild, if there was any authentication error in any call |
|
correct, if there was any authentication. In case what was in memory was good, no change needed. |
Description
This makes sure the state of suma genserver is cleared up always when clearing software updates settings, otherwise might happen that genserver state is kept, causing discoveries to happen when they should not.
How was this tested?
Automated tests and on a real infrastructure.