Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track software update discoveries #2540

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Apr 23, 2024

Description

This PR introduces tracking of software updates discovery results.

  • on a successful discovery relevant_patches and upgradable_packages of a host are tracked
  • on a failed discovery the failure reason is tracked (issues when authenticating/system id retrieval/relevant patches retrieval/upgradable packages retrieval)
  • on clear up, relevant previously tracked discoveries are removed

Note that there can be at most one tracked discovery per host, that gets replaced by newer discoveries.

What's next: the tracked discoveries can be queried in /hosts/:host_id/software_updates and possibly later also on overviews.

How was this tested?

Automated tests and manually.

@nelsonkopliku nelsonkopliku self-assigned this Apr 23, 2024
@nelsonkopliku nelsonkopliku force-pushed the improve-suma-consistency branch 4 times, most recently from ca418b6 to b0a8ea0 Compare April 23, 2024 16:55
@nelsonkopliku nelsonkopliku changed the title Improve suma consistency Track software update discoveries Apr 24, 2024
@nelsonkopliku nelsonkopliku force-pushed the improve-suma-consistency branch 3 times, most recently from 3eda5a2 to c2b6202 Compare April 26, 2024 08:00
@nelsonkopliku nelsonkopliku added enhancement New feature or request elixir Pull requests that update Elixir code env Create an ephimeral environment for the pr branch labels Apr 26, 2024
@nelsonkopliku nelsonkopliku marked this pull request as ready for review April 26, 2024 08:24
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The approach is fine, the naming of some functions doesn't sound so good but I think we can revisit this later

@nelsonkopliku nelsonkopliku merged commit 4ddc8af into main Apr 29, 2024
26 checks passed
@nelsonkopliku nelsonkopliku deleted the improve-suma-consistency branch April 29, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request env Create an ephimeral environment for the pr branch
Development

Successfully merging this pull request may close these issues.

None yet

2 participants