Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hana scale out no hooks #2541

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Fix hana scale out no hooks #2541

merged 3 commits into from
Apr 25, 2024

Conversation

arbulu89
Copy link
Contributor

Description

Fix 2 things in HANA scale out clusters discovery:

  • Split properly the secondary site name. Using simply _ caused errors if the site name has this character
  • Use a more global attribute to get the secondary sync state

How was this tested?

New test added and tested with scenario given by Alberto

@arbulu89 arbulu89 added enhancement New feature or request env Create an ephimeral environment for the pr branch labels Apr 23, 2024
abravosuse
abravosuse approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@abravosuse abravosuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on HANA scale-out cluster with no hooks. It works.

@arbulu89 arbulu89 marked this pull request as ready for review April 23, 2024 09:13
@arbulu89 arbulu89 added the bug Something isn't working label Apr 23, 2024
rtorrero
rtorrero reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment, when clarified we are good to go 👍

lib/trento/discovery/policies/cluster_policy.ex Show resolved Hide resolved
@abravosuse
Copy link
Contributor

@arbulu89 confirmed that the discovery of clusters with srHooks enabled still works with these changes.

@arbulu89 arbulu89 merged commit 658d22d into main Apr 25, 2024
99 of 101 checks passed
@arbulu89 arbulu89 deleted the fix-hana-scale-out-no-hooks branch April 25, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtorrero rtorrero rtorrero approved these changes

@abravosuse abravosuse abravosuse approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

@EMaksy EMaksy Awaiting requested review from EMaksy

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request env Create an ephimeral environment for the pr branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arbulu89 @abravosuse @rtorrero