Manage npm dependencies #2582
Merged
Manage npm dependencies #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canvas is used as an indirect dependency of jsdom and should not be listed in the npm dependency section.
This commit moves "@storybook/client-api" and "postcss-import" to the devDependencies section of the package file. These dependencies are not referenced in runtime source code and only used in the test and build process.
dottorblaster
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These patches removes
canvasas direct dependency, as it is only used indirectly byjsdom. Furthermore, it movespostcss-importand@storybook/client-apito the development dependency section, as they are used in testing and compilation.Eventually, as part of a npm audit warning, it increments the patch version of
eslint-config-airbnb-basefrom 6.3.0 to 6.3.1.More information are available in the commit history.
How was this tested?
To verify that nothing broke, I ran the jest test suite and ensured that storyblock is still working as expected.