Discover SAP system running on a JAVA stack #2820
Open
+1,442
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
added
enhancement
EMaksy
force-pushed
the
java_discovery_frontend
branch
from
386fe76
to
0c7a902
Compare
EMaksy
force-pushed
the
java_discovery_frontend
branch
from
0c7a902
to
21b3186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will enable the discovery of a SAP system running on a JAVA stack. A Java sap system is discovered and displayed in the SAP systems overview.
This pr adds a Type field in the Sap systems overview view, so the user can directly see if the discovered system is running on ABAP, JAVA or in a ABAP/JAVA.
Note: This pr contains a lot of almost duplicated back-end tests, this was needed to cover the new check for a sap system.
Previously we checked if a sap system runs on ABAP, now we check for ABAP and/or JAVA.
Preview from Storybook
Did you add the right label?
How was this tested?
Added fronted test
Fixed cypress e2e test (New e2e tests will be added in a second pr as this pr gets a little bit too big)
Updated existing and added new back-end sap systems tests.
Updated storybook
DONE
Did you update the documentation?
No updates needed at this point.