Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include cluster field in the host details view #476

Merged
merged 1 commit into from May 2, 2022
Merged

Include cluster field in the host details view #476

merged 1 commit into from May 2, 2022

Conversation

arbulu89
Copy link
Contributor

Cluster field always was empty:

Linkable cluster:
image

Non linkable cluster:
image

@arbulu89 arbulu89 added the bug Something isn't working label Apr 29, 2022
fabriziosestito
fabriziosestito approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!!

dottorblaster
dottorblaster approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, a touch of Prettier and we can go

nelsonkopliku
nelsonkopliku requested changes Apr 29, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little naming issue :trollface:

assets/js/state/selectors/index.js Outdated Show resolved Hide resolved
@arbulu89 arbulu89 force-pushed the include-cluster-field-host-details branch from 8d301b0 to 4251e58 Compare April 29, 2022 13:35
@dottorblaster dottorblaster merged commit 98a4eb9 into main May 2, 2022
@dottorblaster dottorblaster deleted the include-cluster-field-host-details branch May 2, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arbulu89 @dottorblaster @fabriziosestito @nelsonkopliku