Sap system details e2e #529
Conversation
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
nelsonkopliku
arbulu89
force-pushed
the
sap-system-details-e2e
branch
from
69fac43
to
49feb5e
Compare
test/e2e/cypress/fixtures/sap-system-details/sap_system_details.feature
Outdated
Show resolved
Hide resolved
| }); | ||
| /* This test is commented because there is not any option to remove added SAP instances or | ||
| resetting the database afterwards, and it affects the rest of the test suite. | ||
| it(`should show a new instance when an event with a new SAP instance is received`, () => { |
There was a problem hiding this comment.
This test would be about showing a newly discovered instance on the current sap system? Right?
Adding an extra fixture wouldn't work because it would affect all other tests, correct?
I believe this is calling for a more refined way to interact with the state in e2e test.
There was a problem hiding this comment.
The test actually works, and the functionality too, but as future tests are only based in the original 27 nodes landscape, and we are not able to remove the recently added instance, everything else starts failing.
Here there are 2 solutions:
- We implement the option to reset the database and start in a clean env
- We implement the SAP instances de-registration (this is actually a feature that is already in our backlog)
There was a problem hiding this comment.
Implementation of the SAP instance de-registration is, as you mention, something on the backlog we'll be working on.
So I'd keep it out from this discussion.
If I am understanding properly, the problem is that when we load the scenario sap-system-detail-NEW - or any scenario - we change the state and other tests would be negatively impacted by this.
cy.loadScenario(`sap-system-detail-NEW`);By having the resetDatabase command in cypress we'd be able to clean up the state and restart.
I am afraid this might turn out not that straightforward because elixir complains about playing around with the database it is connected to (dropping, recreating databases/tables)
There might be other strategies playing with also photofinish but I am not sure right now.
We might want to further discuss this.
I believe since we are working on the e2e debt, it would be beneficial to also take into account this activity.
There was a problem hiding this comment.
@nelsonkopliku Ticket for this reset database topic created in our team backlog as tech-debt
There was a problem hiding this comment.
LGTM.
I would track the outcome of this discussion #529 (comment)
Add E2E tests for the SAP system details view, ported from the old trento legacy project.
Besides that, I have taken advantage and unify the links to the host details view using the new component
HostLink