General browser fixes for collapsed sidebar #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
approved these changes
Oct 19, 2022
jagabomb
commented
Oct 19, 2022
| '-scale-100': isCollapsed, | ||
| })} | ||
| /> | ||
| {isCollapsed ? ( |
There was a problem hiding this comment.
@dottorblaster So I am now using two implementations of the EOS Keyboard Double Arrow icons but it @arbulu89 had a suggestion to create a React component for both icons so that we can reduce the repeated attributes for size, color and classname. What do you think?
There was a problem hiding this comment.
@jagabomb a component would be an overkill to me, maybe we can try just defining these things as const?
There was a problem hiding this comment.
@dottorblaster Cool, I have defined the three const values in a new commit.
dottorblaster
pushed a commit
that referenced
this pull request
Oct 21, 2022
* General browser fixes for collapsed sidebar * Formatted using Prettier * Added EOS Keyboard Double Arrow Right icon * Changed position of title tag for Sidebar menu items * Added three const values for sidebar icon color, size and classname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor improvements to remove issues in Safari browser with collapsed sidebar elements. Also changed implementation of Double Arrow Left icon to library standard due to fix with icon library.
Fixes:
Issue with icon not changing direction when the sidebar is collapsed in Safari.
Alignment of Trento logo not being centred when the sidebar is collapsed in Safari.
How was this tested?
Visually in Safari and Chrome