-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighthouse Plugin doesn't work without hacks #16
Comments
Thanks. Should be sorted with this GoogleChrome/lighthouse#9997 |
@roelfjan can you take a look at the changes and tell me if you think that'd resolve this issue? (also technically this issue probably belongs in the LH repo but no big deal.. i appreciate the report) |
Ah I see that this is indeed a report for the action, my bad. +@connorjclark Anyway it's mostly our (lighthouse-core) bug. :/ |
I forked your repo - thanks for setting that up and making it real easy to dig into. https://github.com/connorjclark/lighthouse-plugin-sample-project few things here:
I believe we can avoid this hairy issue pretty simply. This treosh action should accept a parameter |
Great work, thanks for the fix! I also updated my blogpost. |
Great! BTW - I don't see the updated content. Still in draft? |
'Works on my machine'? Also checked it a on another machine. It should contain |
I missed that update banner. I saw some things that looked like the old post but it looks great now. Thanks for the bug report! |
I created a sample project with a Lighthouse Plugin for my blogpost: https://engineering.q42.nl/making-a-lighthouse-plugin-work-with-lighthouse-ci/.
I couldn't get it to work on GitHub Actions without adding the lines:
Otherwise it gave te error messages:
Runtime error encountered: Cannot find module 'lighthouse'
Runtime error encountered: Unable to locate plugin: lighthouse-plugin-field-social-sharing
My sample repo is: https://github.com/Q42/lighthouse-plugin-sample-project
The text was updated successfully, but these errors were encountered: