Configure NODE_PATH to load plugin from GitHub workspace #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
requested changes
Nov 25, 2019
There was a problem hiding this comment.
I like this change. It's a reasonable solution to #16. I want some docs in the README/recipes section on how to use this. As far as I understand it, we want 2 situations to be documented, right?
- I am developing a new plugin, and want to test it with this action from the repo in which I am developing that new plugin.
- I am developing some web project, and want to run this action with a plugin that I can get from
npm.
src/index.js
Outdated
| @@ -1,8 +1,21 @@ | |||
| // Append the node_modules of the github workspace and the node_modules of this action | |||
| // to NODE_PATH. This supports lighthouse plugins - all the workspace needs to do it | |||
There was a problem hiding this comment.
I think this comment is enough, then explain more in detail in the docs.
Suggested change
| // to NODE_PATH. This supports lighthouse plugins - all the workspace needs to do it | |
| // to NODE_PATH. |
alekseykulikov
requested changes
Nov 26, 2019
alekseykulikov
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
This change supports plugins w/ no changes to a workspace config, other than running
npm/yarn install. See my example repo: https://github.com/connorjclark/lighthouse-plugin-sample-project/blob/master/.github/workflows/main.yml