Support . in characters and negative numbers
#213
Conversation
|
|
etiennebr
changed the title
. in characters and negative numbers. in characters and negative numbers
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 88.18% 88.18%
=======================================
Files 24 24
Lines 1193 1193
=======================================
Hits 1052 1052
Misses 141 141
Continue to review full report at Codecov.
|
* add tests * allow `.` in string * allow negative int * allow negative numeric fix rstudio#212
R/query-string.R
Outdated
| re[type == "double" | type == "numeric"] <- "\\\\d*\\\\.?\\\\d*" | ||
| re <- rep("[^/]+", length(type)) | ||
| re[type == "int"] <- "-?\\\\d+" | ||
| re[type == "double" | type == "numeric"] <- "-?\\\\d*\\\\.?\\\\d*" |
There was a problem hiding this comment.
Unrelated to your code, but I believe this is actually a bug, as it matches "" as currently written. Do you mind swapping one of the \\\\d*s with a \\\\d+ so that we can be sure that there's at least one digit in the string (as we do with int)?
There was a problem hiding this comment.
Ok, you're right. I'll use -?\d*\.?\d+ which would match e.g. .23, which can be interesting, I guess.
|
Everything looks great except that the |
* don't match `.` * don't match empty string ""
|
Sorry about the |
|
Awesome! Thanks again. |
This is in relation to #212. I don't know how is your code coverage for tests, but it seems to pass. I was expecting to break more things, especially the
.in characters since it was explicitly excluded. I'd be happy to change the pull request if needed.