prevent default for non-absolute links in accordion

trevanhetzel · Oct 7, 2014 · b5417a2 · b5417a2
1 parent 1b3a2dd
commit b5417a2
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/js/barekit.js b/js/barekit.js
@@ -44,11 +44,18 @@ Accordion.prototype.onClick = function (e) {
 	var $target = $(e.target);
 
 	if ($target.is('a')) {
-		e.preventDefault();
+
+		//prevent default behaviour on non-absolute links
+		var href = $target.attr("href");
+		if (href == "#") {
+			e.preventDefault();
+		}
+
 		var $content = $target.parent().next('dd');
 
 		this.processOptions($target, $content);
 	}
+
 };
 
 Accordion.prototype.processOptions = function ($target, $content) {

diff --git a/js/barekit.min.js b/js/barekit.min.js
diff --git a/src/modules/accordion.js b/src/modules/accordion.js
@@ -28,11 +28,18 @@ Accordion.prototype.onClick = function (e) {
 	var $target = $(e.target);
 
 	if ($target.is('a')) {
-		e.preventDefault();
+
+		//prevent default behaviour on non-absolute links
+		var href = $target.attr("href");
+		if (href == "#") {
+			e.preventDefault();
+		}
+
 		var $content = $target.parent().next('dd');
 
 		this.processOptions($target, $content);
 	}
+
 };
 
 Accordion.prototype.processOptions = function ($target, $content) {