Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent l_p value used in detector #5

Closed
gehuangyi20 opened this issue May 21, 2018 · 1 comment
Closed

inconsistent l_p value used in detector #5

gehuangyi20 opened this issue May 21, 2018 · 1 comment

Comments

@gehuangyi20
Copy link

In the original paper section 5.2.1, the paper said

Detector II and detector I(see Table 3) used the $L^2$ and $L^1$ norm to measure reconstruction error, respectively.

However, in the following implementation, you use L1 for detector II and L2 for detector I.

detector_I = AEDetector("./defensive_models/MNIST_I", p=2)

detector_II = AEDetector("./defensive_models/MNIST_II", p=1)

I am asking is this a just typo? Can you confirm which one should be the correct one.

It seems the code in the repo gives the better result.

@Trevillie
Copy link
Owner

Hi @gehuangyi20

As far as I recall, that should be a typo in the paper. Thanks for the notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants