-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit test to test labelling with floats on the x_axis #84
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #84 +/- ##
==========================================
+ Coverage 97.04% 97.06% +0.01%
==========================================
Files 29 29
Lines 1898 1907 +9
==========================================
+ Hits 1842 1851 +9
Misses 56 56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JasonMendoza2008 , thanks for the quick reply and PR, I appreciate it!
I left a few comments in case you're willing and have the time to go a little further with it.
As before, please let me know if I can be of assistance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JasonMendoza2008 !
Thanks for the update. Nice job! We are about ready here, except for two minor things about unnecessary diff.
If possible, would you also please squash your commits into a single one? (You'll then have to force push the branch on github)
Unit tests to test labelling with floats on the x_axis
Hello @trevismd |
@trevismd anything I should do? Tests failed on |
Thank you for your contribution and patience, @JasonMendoza2008 ! |
To enhance tests for float values on the x_axis (they are currently supported). Also added PyCharm IDE files to the .gitignore file to avoid accidental commit of these files. Refers to this issue: #65
Not sure if the test is properly coded (EDIT: second commit should make the whole thing closer to what was already in place). In case the commit is not clear, here is the code (user-oriented) to create the figure and make sure the result is the one expected that I used as inspiration to make the unit test (I checked it did not run and now runs with your latest commits):