-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme tweaks #1
Conversation
README.md
Outdated
- folder: ./helpers | ||
- filename: "[[FRAMEWORK]]/helpers/levurehelper-file_browser" | ||
- filename: "[[FRAMEWORK]]/helpers/levurehelper-dataview" | ||
- filename: "[[FRAMEWORK]]/helpers/levurehelper-dataview_tree" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macMikey These helper paths are incorrect as the helpers are not distributed with the Levure framework. You don't need to modify the app.yml file at all since the helpers are added to the ./app/helpers folder. The default app.yml file includes all helpers in the ./app/helpers folder.
I don't have helpers specifically called out in app.yml for the heck of it. What the heck was the problem we ran into if we did just |
I don't recall a problem with just using |
Oh FRICK I realized that I had ```[[FRAMEWORK]] in the readme. #FALE |
92389b1
to
9950bfe
Compare
Have a look at that. |
README.md
Outdated
To include the File Browser Dataview control in your project (using git): | ||
1. Submodule the File Browser Dataview control https://github.com/trevordevore/levurehelper-file_browser to app/helpers/levurehelper-file_browser | ||
2. Submodule the DataView helper https://github.com/trevordevore/levurehelper-dataview to app/helpers/levurehelper-dataview | ||
3. Submodule the DataView Tree helper https://github.com/trevordevore/levurehelper-dataview_tree to app/helpers/levurehelper-dataview-tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@macMikey I would recommend that the submodule folder names strip out levurehelper-
. For example, app/helpers/dataview-tree
. I use levurehelper-
as prefixes on the repo names but within the app itself I like to strip it out because it looks nicer.
* Add instructions for including the helper, including submoduling, ad modifying app.yml * Fix typos * Made the example a ```mouseup``` handler since it's an example.
better? |
mouseup
handler since it's an example.