Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected top space height change when echo area height changes #18

Merged
merged 1 commit into from Apr 26, 2022

Conversation

trevorpogue
Copy link
Owner

@trevorpogue trevorpogue commented Apr 26, 2022

Resolves #16

  • Change default value for topspace-autocenter-buffers to
    topspace-default-autocenter-buffers function
  • Add condition to topspace-default-autocenter-buffers so that it
    returns nil if user has scrolled buffer in the selected window before.

Cosmetic changes:

  • Move default function values for some defcust's to User functions section

Checklist

  • I have read the topspace contributing guidelines
  • My changes follow the Emacs Lisp conventions and the Emacs Lisp Style Guide
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • The new code is not generating bytecode warnings
  • I've updated the readme (if adding/changing user-visible functionality)
  • I have confirmed some of these without doing them

- Change default value for `topspace-autocenter-buffers` to
  `topspace-default-autocenter-buffers` function
- Add condition to `topspace-default-autocenter-buffers` so that it
  returns nil if user has scrolled buffer in selected window before.
- Move default function values for some defcust's to User functions section
@trevorpogue trevorpogue merged commit 2f35223 into main Apr 26, 2022
@trevorpogue trevorpogue deleted the eldoc branch April 26, 2022 21:34
@trevorpogue trevorpogue added the bug Something isn't working label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confict with multiple lines in ElDoc
1 participant