Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where topspace-mode doesn't work locally #6

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

trevorpogue
Copy link
Owner

Resolves #5

  • Allow topspace to work locally
  • Add guards around advice-add functions to only modify functions when topspace is both enabled and active in current buffer
  • Never remove advice-add because the modified functions will effectively not be changed when topspace is not enabled. Removing the advice-add at the correct time may be a bit difficult and error-prone because this would mean keeping track of when topspace is no longer enabled in any buffers (but not impossible to do maybe later on)
  • A few minor cosmetic changes and clarifications in docstrings

Checklist

  • I have read the topspace contributing guidelines
  • My changes follow the Emacs Lisp conventions and the Emacs Lisp Style Guide
  • I've used the latest version of package-lint to check for packaging issues, and addressed its feedback
  • The new code is not generating bytecode warnings
  • I've updated the readme (if adding/changing user-visible functionality)
  • I have confirmed some of these without doing them

@trevorpogue trevorpogue merged commit 8493ed0 into main Mar 17, 2022
@trevorpogue trevorpogue deleted the cant-enable-locally branch March 17, 2022 18:43
@trevorpogue trevorpogue added the bug Something isn't working label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local topspace-mode affects other buffers, too
1 participant