[Update]Fix missing greater_is_better decision when choosing the best program #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for the PR @eggachecat ... Can you expand this PR to cover both issues outlined in #42 ? Also some regression tests would be excellent. Doesn't have to be extensive, just a short (smallish population, few generations) to ensure the best programs make it to the "solution(s)" |
|
@trevorstephens okay! I'll do it! |
|
Awesome, thanks! |
eggachecat
changed the title
eggachecat
commented
Aug 3, 2017
| @@ -479,7 +479,11 @@ def fit(self, X, y, sample_weight=None): | |||
| if isinstance(self, TransformerMixin): | |||
| # Find the best individuals in the final generation | |||
There was a problem hiding this comment.
I don't think this will completely allow all kinds of customized metrics ( e.g. selecting models other than correlation approach), since the content below written in hard code is based on correlation ..
|
clearly something went wrong..I will reopen a PR with my branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing greater_is_better decision when choosing the best program