#934 Added command to clear all data in the table: #950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trey-wallis hi, could you check the PR please?
The only place I doubt is that I had to duplicate the possible values that can be passed to
textVariant
. Now there are two places in the plugin where this enumeration is present ("semibold" | "faint" | "muted" | "on-accent" | "error" | "normal"
). This is in theMenuItem.textVariant
definition and inText.variant
. It would be nice to get this definition into a single place, but I had no idea how. In general, you could put these values in enum, but then backward compatibility and the ability to set thevairant
property with string would break.