Mirror puppet-module-mofed nm_controlled behavior #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint issues are missing documentation at top of file. Something like this: |
* Replace CentOS 8 support with Rocky/AlmaLinux 8 * Fix fixtures file * Fix unit tests
|
If you rebase against master or merge master into this pull request, that should fix the broken testing. |
|
Okay, rebased. Let me know if you need any other changes. |
|
The unit tests fixtures need updates to account for changed contents of ifcfg files. Similar to here: https://github.com/treydock/puppet-module-mofed/pull/23/files |
|
Gotcha. I will work on adding those.
…-Paul Edmon-
On 8/19/22 3:01 PM, treydock wrote:
The unit tests fixtures need updates to account for changed contents
of ifcfg files. Similar to here:
https://github.com/treydock/puppet-module-mofed/pull/23/files
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJVDT5MY4W3LY4HDLH3K33VZ7KYHANCNFSM566B46AA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Done. |
|
This will be released with v4.1.0 once Github Actions complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For comparison see: treydock/puppet-module-mofed#23