Support installation from EPEL

[traylenator]

Now that apptainer is available from EPEL allow installations with traditional package installation.

[traylenator]

Sorry have not run the tests locally (failed to install gemset) so 🤞 ...

[traylenator]

Apologies I forced pushed with out realising you had reviewed, in particular the apptianer-suid package may need to be installed.

I will make the changes you have suggested.

[treydock]

I think only thing missing is acceptance test for the os install method. https://github.com/treydock/puppet-module-apptainer/blob/main/spec/acceptance/01_class_spec.rb. - I wouldn't worry about testing downgrade/upgrade like the other tests, just validate can install apptainer from OS packages. I think likely easiest to add your tests as first ones in the file and just remove the OS packages at beginning of next set of tests.

[traylenator]

Re theissing yumrepo do spec tests use fixtures file or metadata file?

[treydock]

Re theissing yumrepo do spec tests use fixtures file or metadata file?

The unit tests use .fixtures.yml but the acceptance tests use metadata.json but for yumrepo_core, that's part of puppet-agent so don't need to include in metadata.json usually.

[treydock]

I can't get EL7 tests to pass. Something is broken with docker testing that I can't reproduce on my laptop. I did some updates in another PR to add install_setuid parameter and fix some other failing tests.

[treydock]

@traylenator I had to update main branch to support Apptainer 1.1.x and that required doing the EPEL adds there. So now the only change necessary in this PR is adding the OS install bits, the EPEL inclusion is done in init.pp.

[traylenator]

Yep noticed some of that, and the new install_suid (or what ever it is) parameter which I'll take note of.

[traylenator]

By the way , feel free to request a review from me in the future.

[traylenator]

acceptence tests fail since signularity module is not present but that is not surprising, unclear to me how it passed previously...

[treydock]

I removed the singularity tests because it's no longer possible to install singularity packages since apptainer obsoletes singularity packages.

[treydock]

acceptence tests fail since signularity module is not present but that is not surprising, unclear to me how it passed previously...

In recent PRs I removed the singularity module and singularity tests because it's no longer possible to install singularity RPMs from EPEL as apptainer now provides the singularity package via obsoletes I believe.

[traylenator]

Test failures look unrelated.

[treydock]

They are unrelated. Something is broken with CentOS 7 tests and what's odd is other modules I have use exact same setup for testing and don't have this issue.

[treydock]

This will be released with 1.0.0 once the Github Actions complete.