Add support for required actions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
ZloeSabo
changed the title
ZloeSabo
force-pushed
the
feature/add-required-actions
branch
from
ae4b392
to
e4a70b0
Compare
Required actions are actions a user must perform during the authentication process. A user will not be able to complete the authentication process until these actions are complete. For instance, change a one-time password, accept T&C, etc. Matching is done by the combination of alias and realm.
ZloeSabo
force-pushed
the
feature/add-required-actions
branch
from
e4a70b0
to
a35bf25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required actions are actions a user must perform during the authentication process. A user will not be able to complete the authentication process until these actions are complete. For instance, change a one-time password, accept T&C, etc.
Note
I deliberately did not add auto requires as it complicates the deconfiguration process. I.e. if I specify
ensure => absentfor both required_action and realm and the former auto requires the latter, then the realm would be deleted first and the puppet run would fail on deleting actions because they're specific to a realm and the realm no longer exists.