New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for logging to syslog #190
Conversation
Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
- fix extra empty line detected at block body end Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
manifests/init.pp
Outdated
String $syslog_facility = 'user-level', | ||
String $syslog_hostname = $facts['fqdn'], | ||
String $syslog_level = 'INFO', | ||
String $syslog_port = '514', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this an integer value and of type Stdlib::Port
manifests/init.pp
Outdated
Boolean $syslog = false, | ||
String $syslog_app_name = 'keycloak', | ||
String $syslog_facility = 'user-level', | ||
String $syslog_hostname = $facts['fqdn'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be of type Stdlib::Host
Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
I would recommend adding an acceptance test so that in this context, https://github.com/treydock/puppet-module-keycloak/blob/master/spec/acceptance/1_class_spec.rb#L131 , change to set
And call it like "reset back to defaults" or something. So far looks like only remaining issues are data types used for |
Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
@kibahop Thanks for the pull request, this will be released as v7.2.0 |
Signed-off-by: Kibahop petri.lammi@puppeteers.net