Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logging to syslog #190

Merged
merged 5 commits into from Mar 26, 2021
Merged

Conversation

kibahop
Copy link
Contributor

@kibahop kibahop commented Mar 18, 2021

Signed-off-by: Kibahop petri.lammi@puppeteers.net

Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
- fix extra empty line detected at block body end

Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
manifests/init.pp Outdated Show resolved Hide resolved
manifests/config.pp Outdated Show resolved Hide resolved
String $syslog_facility = 'user-level',
String $syslog_hostname = $facts['fqdn'],
String $syslog_level = 'INFO',
String $syslog_port = '514',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this an integer value and of type Stdlib::Port

Boolean $syslog = false,
String $syslog_app_name = 'keycloak',
String $syslog_facility = 'user-level',
String $syslog_hostname = $facts['fqdn'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be of type Stdlib::Host

Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
@treydock
Copy link
Owner

I would recommend adding an acceptance test so that in this context, https://github.com/treydock/puppet-module-keycloak/blob/master/spec/acceptance/1_class_spec.rb#L131 , change to set syslog => true and then maybe add another context after that one where the class definition is this:

      include mysql::server
      class { 'keycloak':
        datasource_driver => 'mysql',
      }

And call it like "reset back to defaults" or something.

So far looks like only remaining issues are data types used for syslog_hostname and syslog_port.

Signed-off-by: Kibahop <petri.lammi@puppeteers.net>
@treydock treydock merged commit 19aff1c into treydock:master Mar 26, 2021
@treydock
Copy link
Owner

@kibahop Thanks for the pull request, this will be released as v7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants