Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backchannel logout url attribute #237

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

wolfaba
Copy link
Contributor

@wolfaba wolfaba commented Mar 10, 2022

No description provided.

@wolfaba
Copy link
Contributor Author

wolfaba commented Mar 10, 2022

dear @treydock
I hope this is, what you wanted and I hope it's correct.
I very sorry if it's not correct, but I am just sysadmin, neither ruby nor puppet module developer. I was able to add the backchannel logout URL only because the module is written really good and even that I'm not profi, I have understood (hopefully) the functionality and could extend the code.
Thank you.
Regards.
Robert.

Comment on lines 163 to 164
end

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
end
end

The validation tests are failing because of trailing white space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you

@treydock treydock merged commit 6c564c1 into treydock:master Mar 14, 2022
@treydock
Copy link
Owner

This will be released with v7.14.0. The forge release will be present once Github Actions complete

@wolfaba
Copy link
Contributor Author

wolfaba commented Mar 14, 2022

thank you

@wolfaba wolfaba deleted the logout branch March 18, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants