Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow slurmdbd_storage_port to be an empty string (support socket connection to DB) #58

Merged
merged 1 commit into from Apr 16, 2024

Conversation

jakerundall
Copy link
Contributor

Allow slurmdbd_storage_port to be an empty string ("" or ''), which supports slurmdbd connecting to the DB via a socket rather than via TCP/IP.

Adjust the template for slurmdbd.conf so that if any value is an empty string (''), then put "" in as the value.

See #57 .

@treydock treydock added the bugfix Something isn't working label Mar 25, 2024
@treydock
Copy link
Owner

A unit test for the new behavior would be ideal, similar to this:

context 'when slurmdbd_storage_pass => "foobar"' do
let(:param_override) { { slurmdbd_storage_pass: 'foobar' } }
it 'overrides values' do
verify_contents(catalogue, 'slurmdbd.conf', ['StoragePass=foobar'])
end
end

@treydock
Copy link
Owner

Might also need to rebase after some recent updates

Allow slurmdbd_storage_port to be an empty string ("" or ''), which supports
slurmdbd connecting to the DB via a socket rather than via TCP/IP.

Adjust the template for slurmdbd.conf so that if any value is an empty string (''),
then put "" in as the value for StoragePort.
@jakerundall
Copy link
Contributor Author

OK, ready for another look, thanks! Sorry for the delay.

@treydock treydock merged commit 11ac47a into treydock:master Apr 16, 2024
14 checks passed
@treydock
Copy link
Owner

This is being released with v4.0.1 once Github Actions complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants