Properly handle changes to AdminLevel for users

lib/puppet/provider/sacctmgr.rb

@@ -77,6 +77,10 @@ def self.fields_name_overrides
     {}
   end
 
+  def property_skip_set_values
+    []
+  end
+
   def self.sacctmgr_resource
     case resource_type.to_s
     when 'Puppet::Type::Slurm_cluster'
@@ -242,6 +246,7 @@ def set_values(create) # rubocop:disable Style/AccessorMethodName
                    @property_flush.keys
                  end
     properties.each do |property|
+      next if property_skip_set_values.include?(property.to_sym) && !create
       value = if create
                 resource[property]
               else
@@ -310,8 +315,14 @@ def flush
         cmd << "cluster=#{@resource[:cluster]}" if @resource[:cluster]
       end
       cmd << 'set'
-      cmd << set_values(false)
-      sacctmgr(cmd.flatten)
+      values = set_values(false)
+      cmd << values
+      unless values.empty?
+        sacctmgr(cmd.flatten)
+      end
+      property_skip_set_values.each do |p|
+        send("set_#{p}")
+      end
     end
     @property_hash = resource.to_hash
   end

lib/puppet/provider/slurm_user/sacctmgr.rb

@@ -24,6 +24,10 @@ def self.array_properties
     [:qos]
   end
 
+  def property_skip_set_values
+    [:admin_level]
+  end
+
   def self.instances
     users = []
     sacctmgr_list(true).each_line do |line|
@@ -73,6 +77,14 @@ def initialize(value = {})
     end
   end
 
+  def set_admin_level
+    value = @property_flush[:admin_level]
+    return if value.nil?
+    Puppet.notice("Setting SLURM adminlevel=#{value} for user=#{resource[:user]}")
+    cmd = ['-i', 'modify', 'user', 'where', "user=#{resource[:user]}", 'set', "adminlevel=#{value}"]
+    sacctmgr(cmd)
+  end
+
   def destroy
     if @resource[:user] == 'root'
       Puppet.warning("Slurm_user[#{@resource[:name]}] Not permitted to delete root user. Must define root user or remove cluster")

spec/acceptance/05_user_spec.rb

@@ -57,6 +57,7 @@
         slurm_cluster { 'linux': ensure => 'present' }
         slurm_account { 'test on linux': ensure => 'present' }
         slurm_user { '#{name} under test on linux': ensure => 'present' }
+        slurm_user { 'testuser under test on linux': admin_level => 'Administrator' }
         EOS
 
         apply_manifest(pp, catch_failures: true)
@@ -66,6 +67,9 @@
       describe command("sacctmgr list user format=#{format_string} withassoc --noheader --parsable2") do
         its(:stdout) { is_expected.to include(value) }
       end
+      describe command('sacctmgr list user format=user,adminlevel --noheader --parsable2') do
+        its(:stdout) { is_expected.to include('testuser|Administrator') }
+      end
     end
 
     context 'update' do
@@ -76,6 +80,7 @@
         slurm_cluster { 'linux': ensure => 'present' }
         slurm_account { 'test on linux': ensure => 'present' }
         slurm_user { '#{name} under test on linux': ensure => 'present', grp_tres => {'cpu' => 1} }
+        slurm_user { 'testuser under test on linux': admin_level => 'Operator' }
         EOS
 
         apply_manifest(pp, catch_failures: true)
@@ -85,6 +90,9 @@
       describe command("sacctmgr list user format=#{format_string} withassoc --noheader --parsable2") do
         its(:stdout) { is_expected.to include(value) }
       end
+      describe command('sacctmgr list user format=user,adminlevel --noheader --parsable2') do
+        its(:stdout) { is_expected.to include('testuser|Operator') }
+      end
     end
 
     context 'remove' do