Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Options.module_name, fixes #130 #131

Closed
wants to merge 1 commit into from
Closed

Remove deprecated Options.module_name, fixes #130 #131

wants to merge 1 commit into from

Conversation

ryangallen
Copy link

No description provided.

@macro1
Copy link
Collaborator

macro1 commented Oct 18, 2014

That code was already compatible with the changes coming in 1.8, but we should probably assume the forward-looking state, and fallback for compatibility:

try:
    info = opts.app_label, opts.model_name
except AttributeError:
    info = opts.app_label, opts.module_name

Note I swapped the order of the assignment.

There is similar code in admin.py, it should probably match.

Sorry, I meant models.py.

@macro1 macro1 closed this Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants