Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recovery fails with cannot read property message #12

Closed
mruddy opened this issue Jan 9, 2017 · 6 comments
Closed

recovery fails with cannot read property message #12

mruddy opened this issue Jan 9, 2017 · 6 comments

Comments

@mruddy
Copy link

mruddy commented Jan 9, 2017

Using the Chrome extension (downloaded from the chrome store today), I wipe the Trezor and then attempt to run the recovery.

Every time, without regard to the input values, I receive a "Cannot read property 'name' of undefined" message when I click continue (see screenshot). This is easiest to reproduce when the PIN protection is unchecked because then you don't have to enter a PIN to get the failure.

bug

["log","Mon, 09 Jan 2017 02:08:23 GMT","[trezor] Sending","RecoveryDevice",{"pin_protection":false,"word_count":24,"enforce_wordlist":true}]
["log","Mon, 09 Jan 2017 02:08:23 GMT","[trezor.js event session] send : ","RecoveryDevice",{"pin_protection":false,"word_count":24,"enforce_wordlist":true}]
["error","Mon, 09 Jan 2017 02:08:24 GMT","[trezor] Error received",{"type":"error","message":"Cannot read property 'name' of undefined"}]
["log","Mon, 09 Jan 2017 02:08:24 GMT","[trezord] Received error",{}]
["log","Mon, 09 Jan 2017 02:08:24 GMT","[trezor.js event session] error : ",{}]

Google Chrome Version 55.0.2883.87 (64-bit)
Ubuntu 16.04.1 LTS
1.4.0 Trezor firmware
@karelbilek
Copy link
Contributor

ACK

will look at it

@karelbilek
Copy link
Contributor

It was a bug in the code handling protobuf=>JSON conversion. I have fixed this and will push to chrome store soon :)

@mruddy
Copy link
Author

mruddy commented Jan 11, 2017

cool, thanks for figuring it out. i'll be sure to test it after it's available.

@karelbilek
Copy link
Contributor

karelbilek commented Jan 11, 2017 via email

@mruddy
Copy link
Author

mruddy commented Jan 11, 2017

Excellent, thanks. I've just verified that version 1.2.4 of the extension from the chrome store fixes this issue.
I had to remove and re-install the extension since the chrome store did not seem to have an auto-update. That's probably typical, I've just never used the chrome store before.

@mruddy mruddy closed this as completed Jan 11, 2017
@karelbilek
Copy link
Contributor

karelbilek commented Jan 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants