This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Added code to make trezor-agent work with keepkey. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
force-pushed
the
master
branch
2 times, most recently
from
fe459ea
to
c7c09a7
Compare
prusnak
added a commit
that referenced
this pull request
Feb 10, 2016
Added code to make trezor-agent work with keepkey.
|
Thanks! |
|
Anyway we can get this support for KeepKey removed. This will cause problems with our electrum plugin. |
prusnak
added a commit
that referenced
this pull request
Feb 12, 2016
This reverts commit 53e361b. As requested by @dstanchfield here: #49 (comment)
|
Reverted in 8b7e605. |
|
Thanks! |
|
Hmm, maybe I should hard-code the device IDs in Electrum and not import them from the library headers? |
|
Best would be, of course, to create one plugin that would handle both devices. Keepkey's code is just same as TREZOR code with replaced strings anyway. |
|
It's not the same actually. The plugin code is 99% shared in Electrum. Now if you two could agree on a common single library, that would be the most helpful. I could then indeed eliminate the plugin separation in Electrum, but not until then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you be interested in taking this pull request? It is needed to make Roman's trezor-agent work for keepkey with minimal changes.
Thanks.