Ripple protobuf messages #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Jul 9, 2018
protob/messages-ripple.proto
Outdated
| */ | ||
| message RippleSignTx { | ||
| repeated uint32 address_n = 1; // BIP-32 path. For compatibility with other wallets, must be m/44'/144'/index' | ||
| optional string account = 2; // source account address. This address must be equal to the one derived from the BIP-32 path |
There was a problem hiding this comment.
Can we drop the account field? It seems redundant.
There was a problem hiding this comment.
I wasn't sure about that either. The reason I left it was that it is a confirmation that the user is sending funds from the account they assume. It is used only here.
But I'm not keen on it, maybe it's a bit far-fetched.
tsusanka
force-pushed
the
tsusanka/ripple
branch
4 times, most recently
from
4a678c8
to
1226085
Compare
|
@prusnak I think/hope this is the final version, so it's ready for review |
prusnak
reviewed
Jul 10, 2018
protob/messages-ripple.proto
Outdated
| * - see https://developers.ripple.com/payment.html | ||
| */ | ||
| message RipplePayment { | ||
| optional uint32 amount = 1; // only XRP is supported at the moment so this an integer |
There was a problem hiding this comment.
I think we should use uint64 here (XRP has precision equivalent to a 64-bit integer)
prusnak
reviewed
Jul 10, 2018
protob/messages-ripple.proto
Outdated
| */ | ||
| message RippleSignTx { | ||
| repeated uint32 address_n = 1; // BIP-32 path. For compatibility with other wallets, must be m/44'/144'/index' | ||
| optional uint32 fee = 2; // fee (in drops) for the transaction |
There was a problem hiding this comment.
You're correct. Same goes for the payment's amount, nice catch. I've fixed both
tsusanka
force-pushed
the
tsusanka/ripple
branch
from
1226085
to
1082676
Compare
|
LGTM Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Ripple protobuf messages. Other Ripple PRs will follow in trezor-core and trezor-python after this is merged.