Skip to content
This repository has been archived by the owner on May 28, 2019. It is now read-only.

Unify GetPublicKey's argument show_display #324

Closed
tsusanka opened this issue Aug 20, 2018 · 1 comment
Closed

Unify GetPublicKey's argument show_display #324

tsusanka opened this issue Aug 20, 2018 · 1 comment
Assignees
@tsusanka
Labels
altcoin firmware
Milestone
Altcoins refactoring

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Aug 20, 2018 •
edited
Loading

LiskGetPublicKey and TezosGetPublicKey have a show_display argument, some other GetPublicKey messages don't.

Do we want to provide this option and optionally display the pubkey?
@tsusanka tsusanka added this to the Altcoins refactoring milestone Aug 20, 2018
@tsusanka tsusanka self-assigned this Aug 20, 2018
@tsusanka tsusanka mentioned this issue Aug 20, 2018
Closed
@prusnak
Copy link
Member

prusnak commented Aug 20, 2018

Yes, let's have it IMO.

tsusanka added a commit to trezor/trezor-common that referenced this issue Aug 20, 2018
@tsusanka
protob: cardano's GetPublicKey has show_display arg
564310d 
updates trezor/trezor-core#324
@tsusanka tsusanka mentioned this issue Aug 21, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tsusanka tsusanka

Labels
altcoin firmware
Projects
None yet
Milestone
Altcoins refactoring
Development

No branches or pull requests
2 participants
@prusnak @tsusanka