fixup! feat(common): Add no_script_type option to SignMessage.

trezor · Nov 10, 2021 · ed627c4 · ed627c4
1 parent e7ed41b
commit ed627c4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/common/protob/messages-bitcoin.proto b/common/protob/messages-bitcoin.proto
@@ -152,7 +152,7 @@ message SignMessage {
     required bytes message = 2;                                         // message to be signed
     optional string coin_name = 3 [default='Bitcoin'];                  // coin to use for signing
     optional InputScriptType script_type = 4 [default=SPENDADDRESS];    // used to distinguish between various address formats (non-segwit, segwit, etc.)
-    optional bool no_script_type = 5 [default=false];                   // don't include script type information in the recovery byte of the signature, same as in Bitcoin Core
+    optional bool no_script_type = 5;                                   // don't include script type information in the recovery byte of the signature, same as in Bitcoin Core
 }
 
 /**

diff --git a/core/src/trezor/messages.py b/core/src/trezor/messages.py
@@ -525,7 +525,7 @@ class SignMessage(protobuf.MessageType):
         message: "bytes"
         coin_name: "str"
         script_type: "InputScriptType"
-        no_script_type: "bool"
+        no_script_type: "bool | None"
 
         def __init__(
             self,

diff --git a/python/src/trezorlib/messages.py b/python/src/trezorlib/messages.py
@@ -1071,7 +1071,7 @@ def __init__(
         address_n: Optional[List["int"]] = None,
         coin_name: Optional["str"] = 'Bitcoin',
         script_type: Optional["InputScriptType"] = InputScriptType.SPENDADDRESS,
-        no_script_type: Optional["bool"] = False,
+        no_script_type: Optional["bool"] = None,
     ) -> None:
         self.address_n = address_n if address_n is not None else []
         self.message = message