Add Rust Protobuf #1541
Merged
Add Rust Protobuf #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2021
jpochyla
requested review from
matejcik,
prusnak,
mmilata,
andrewkozlik and
tsusanka
jpochyla
force-pushed
the
rust-protobuf
branch
2 times, most recently
from
46bb818
to
5d9843f
Compare
mmilata
requested changes
Apr 29, 2021
matejcik
reviewed
Apr 29, 2021
|
I think I've mostly fixed the build in CI. Please take a look at my changes @ mmilata/rust-protobuf & feel free to cherry-pick/merge them to this PR. |
|
@mmilata any ideas about the core T1 failure? https://gitlab.com/satoshilabs/trezor/trezor-firmware/-/jobs/1314953794 |
Should be fixed after rebasing to master: 8c6b93e |
mmilata
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
@matejcik great job! The bitcoin-only handling is a massive improvement. Though some enums still make it to the image:
$ tools/check-bitcoin-only core/build/firmware/firmware.bin
Decred details provided but Decred coin not specified.
DecredStakingSpendType
)C#trezor.enums.DecredStakingSpendType
.Q&trezor/enums/DecredStakingSpendType.py
UiConfirmDecredSSTXSubmission
trezor/enums/DecredStakingSpendType.py
NEMImportanceTransferMode
&trezor.enums.NEMImportanceTransferMode
NEMModificationType
trezor.enums.NEMModificationType
NEMMosaicLevy
trezor.enums.NEMMosaicLevy
NEMSupplyChangeType
trezor.enums.NEMSupplyChangeType
CardanoAddressParametersType
CardanoBlockchainPointerType
CardanoAddressType
trezor.enums.CardanoAddressType
CardanoCertificateType
#trezor.enums.CardanoCertificateType
CardanoPoolRelayType
!trezor.enums.CardanoPoolRelayType
LiskTransactionType
trezor.enums.LiskTransactionType
StellarAssetType
MoneroAccountPublicAddress
MoneroMultisigKLRki
MoneroOutputEntry
MoneroRctKeyPublic
!MoneroTransactionDestinationEntry
MoneroTransactionRsigData
MoneroTransactionSourceEntry
TezosBallotType
trezor.enums.TezosBallotType
TezosContractType
trezor.enums.TezosContractType
Still I wish we could merge this soon and perhaps solve this separately as the diff is starting to get unwieldy.
This also includes the capability to build Rust protobuf blobs.
- properly exclude in the trezor/enums folder - generate Rust protobuf blobs in scons Split from "tools: Generate special Protobuf blobs for the Rust codec"
API-compatibility with the original one is retained. Now that we don't need to keep code parity with core, we could do some changes that make life easier. All generated classes are now in one file. This makes github diffs more readable, at the cost of somewhat complicating inspecting individual classes; however, that is something we shouldn't be doing anyway. Enums are now implemented as enum.IntEnum. The original class-level FIELDS member was restored. Each field is now defined via protobuf.Field, which is easier to work with in the codec, AND we're not stuffing defaults and flags into the same field.
matejcik
requested review from
mmilata
and removed request for
prusnak,
tsusanka,
onvej-sl and
andrewkozlik
|
rebased, un-drafted, nits fixed |
mmilata
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds in top of #1540
WIP, needs many fixes in the Python side:
p2pybuild_protobuftrezor.enums, put messages tomocks.